Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys,
This is kind of the continuation of #167, however I took a completely different approach.
My gut feeling tells me that there should be an easy way to turn any
scaffold-eth-2
branch into an extension.This new approach works like this:
yarn create-extension-yolo scaffold-eth-2 {commitHash}
commitHash
is the the last commit which exists in scaffold-eth-2This command collects all the modified files since commitHash and creates an extension called
scaffold-eth-2
yarn cli -e scaffold-eth-2 --dev --skip yo --yolo
This command clones scaffold-eth-2, resets it to
commitHash
and copies the files from the extension.Alternatively we can push the extension to github and use
yarn cli -e moltam89/UniswapX-extension-yolo --skip yo --yolo
In case of my UniswapX branch the process would look like this:
yarn build:dev
Runs the build script
git clone -b UniswapX https://github.com/moltam89/scaffold-eth-2
Clones moltam89/scaffold-eth-2/UniswapX
yarn create-extension-yolo scaffold-eth-2 beefe9dcd2743aaab3be5b85652b6c2f16162601
Creates the extension
yarn cli -e scaffold-eth-2 --dev --skip yo --yolo
or
yarn cli -e moltam89/UniswapX-extension-yolo --skip yo --yolo
Spins up the instance
Notes:
main
branch ofscaffold-eth-2
is used, only hardhat is supported.Cheers,
Tamas